Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better sorting of variants in variant picker and publishing dialogs #9797

Merged
merged 8 commits into from
Feb 15, 2021

Conversation

madsrasmussen
Copy link
Contributor

This PR changes the sorting for the variant picker on a node and all the dialogs related to publishing. The new sorting rules look like this:

  • Always show default language first.
  • Show all mandatory languages (first sorted by publishing state then name).
  • Show all non-mandatory languages (first sorted by publishing state then name).
  • The states are sorted like this: "Published", "Draft", "Not Created".

I have attached a screenshot of how the variant picker looks with the above sorting applied.

Screenshot 2021-02-10 at 14 29 48

The same sorting rules also apply to segments. In the variant picker, the segments are shown as nested lists. In the publishing dialogs, the segments are shown underneath the language they relate to.

The following dialogs have been changed with new sorting:

  • Save
  • Publish
  • Publish with descendants
  • Unpublish
  • Send for approval
  • Schedule

How and what to test:

  • Follow the instructions in this PR to get segments set up: Ability to configure Segmentation #7973
  • Make sure everything is sorted correctly in the variant picker
  • Make sure to test all the above-mentioned dialogs

@nielslyngsoe nielslyngsoe merged commit e6462ed into v8/dev Feb 15, 2021
@nielslyngsoe nielslyngsoe deleted the v8/feature/10273-variant-sorting branch February 15, 2021 10:15
@nul800sebastiaan nul800sebastiaan changed the title V8/feature/10273 variant sorting Better sorting of variants in variant picker and publishing dialogs Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants