Minor optimisation by passing int instead of int? to Umbraco.Content() #9669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shazwazza
added
category/performance
bjarnef
reviewed
Jan 21, 2021
| @@ -103,7 +103,7 @@ protected virtual void ConfigurePublishedContentRequest(PublishedRequest request | |||
| { | |||
| if (_contentId.HasValue) | |||
| { | |||
| var content = Umbraco.Content(_contentId); | |||
| var content = Umbraco.Content(_contentId.Value); | |||
| if (content == null) | |||
| { | |||
| throw new InvalidOperationException("Could not resolve content with id " + _contentId); | |||
There was a problem hiding this comment.
@nzdev @Shazwazza should it use _contentId.Value in InvalidOperationException as well?
There was a problem hiding this comment.
That's not going to have any perf impact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes NA
Description
Minor optimisation by passing int instead of int? to Umbraco.Content.
Pass int to Umbraco.Content instead of int? given we know _contentId has value.