Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to define accept file extensions for FileUpload and use these to determine Media Type for File Uploads #9377

Closed
wants to merge 9 commits into from

Conversation

nielslyngsoe
Copy link
Member

This PR adds the ability to define accepted file extensions for FileUpload and use these to determine Media Type for File Uploads.

Prepare:
Create new Media Type (named "Video") with new File Upload Data type for umbracoFile-property.
Set the accepted file extensions for this new data type to ex.: mov and mp4

Create another set that takes mp3 name it "Sound".

Test Notes:

General testing that uploaded files are made of the Media Type that fits the file extension.
Test creating new items through create menu, see the you can only pick files that matches the file extension.
Test that Media Type "File" still can pick any file.
Test dragging files of these new types get creates as the defined media type.
Check that image files that are not define by any media type are created as media.
Check that folders and other files still works as before.

@nielslyngsoe nielslyngsoe added the category/ux User experience label Nov 10, 2020
@skttl
Copy link
Contributor

skttl commented Nov 18, 2020

I've been wanting this for so long 😍

@nielslyngsoe
Copy link
Member Author

@skttl great! Do you know about other low hanging fruits, that would be great to get solved? This one was quite simple and I think it will help out editors a lot in their work. Especially with the new media picker coming up where we can limit the ability to pick certain media types.

If you like to peek:
#9461

@skttl
Copy link
Contributor

skttl commented Nov 27, 2020

I'll give it a spin later - looks promising!

@nielslyngsoe
Copy link
Member Author

@skttl cool, still in progress :-) but let us know what you think

@emma-hq
Copy link
Contributor

emma-hq commented Feb 7, 2022

Hey Niels! I'm going to close this one as we have the functionality as part of mediapicker v3. I'm going to check for any functionality we don't already have that is in here and raise issues accordingly.

@emma-hq emma-hq closed this Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/ux User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants