Refactoring server names from Master to Primary

[lars-erik]

This is as much work that can be done to fix #9088 in V8.

There's one usage of ServerRole.Master and quite a lot of IsMaster properties that can't be changed without breaking comptibility. Rest will have to be done to unicore. 🤷‍♂️

I've set up two identical websites and tested publishing from the primary one using the new enum value. Seems legit:

Docs have a sibling PR at umbraco/UmbracoDocs#2779.

[lars-erik]

I've got two branches of this. This one for just adding to the enum, and one for renaming more IsMasters. Already it seems there are lurking breaking changes. Might just see about changing docs and keeping this, then do the rest of the renamings in the unicore project?

[umbrabot]

Hi there @lars-erik,

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

As a new choice this year, you can opt-out of receiving anything and ask us to improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before February 26, 2021.

Following this date we'll be sending out all the swag, which also means that it might not reach your doorstep before April, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco Teams

[umbrabot]

Hiya @lars-erik!

We wanted to thank you for your work and let you know that we have spent some time reviewing the contribution and have decided that we are going to close this one.

While reviewing this PR, the team left the following additional note:

This has been implemented for v9.

We appreciate that you have worked hard to build and document this contribution to create the changes you want to see but given the status of Umbraco 8, moving into LTS and Umbraco 9 being ready and stable and packed with new features, we are working through the open PRs and deciding which are a good fit for the last version 8 minor and which are not.

If you'd like to know a little more about this process, please check out this blog post, explaining how we came to the decisions we have made here. We'd like to reassure you though that the CMS team, along with some special guests, took the time to assess each PR that is being closed and decided how to proceed - whilst the message you're receiving is automatic, the work behind it was done by the people that make up the CMS team, along with community members.

If there are specifics around this PR that you'd like explained that are not covered by the article, please let us know.

All the best to you, our wonderful contributor.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂