Improve performance and reduce memory use and reduce array allocations by reusing char[] #9166
Conversation
Reduce memory use and improve performance by reducing array allocations
…nto v8/feature-reduce-params-allocations
….com/nzdev/Umbraco-CMS into v8/feature-reduce-params-allocations
This reverts commit faf6b60.
There was a problem hiding this comment.
Hi @nzdev, I've eyeballed all the file changes, everything looks fine. I see no reason not to make these changes, but pinging @Shazwazza in case he has any input before I merge.
There was a problem hiding this comment.
Yeah looks good! @nathanwoulfe feel free to merge/tag for next release :)
Shazwazza
added
the
category/performance
|
@nathanwoulfe you still ok to merge this one or waiting on something? |
|
@Shazwazza absolutely. I think it got lots in my piles of notifications. |
|
Hi there @nzdev, First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇 Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉 In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you! As a new choice this year, you can opt-out of receiving anything and ask us to improve the planet instead by planting a tree on your behalf. 🌳 Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before February 26, 2021. Following this date we'll be sending out all the swag, which also means that it might not reach your doorstep before April, so please bear with us and be patient 🙏 The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help! Kind regards, |
nul800sebastiaan
added
hacktoberfest/contrib-2020
and removed
hacktoberfest-accepted
labels
Prerequisites
If there's an existing issue for this PR then this fixes N/A
Description
What?
Introduced Umbraco.Core.Constants.CharArrays.
Replaced instantiations of common char[] by reusing readonly char[]. Also replaced implicit new char[]'s when params char[] methods are called.
Why?
Reduce allocations, reduce memory use, improve performance.
How to test?
Existing tests pass.