Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formlulate the block list delete confirmation as a question #9139

Merged

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Oct 12, 2020

Prerequisites

  • I have added steps to test this contribution in the description below

Description

The current delete confirmations for block list (content editing) and block list configuration (data type editing) aren't exactly formulated as questions:

image

image

This PR updates the confirmation dialog messages so they are actual questions:

image

image

And yes... I know. Hacktober. Translation PR's. Buuuuut I have already fulfilled my quota for Hacktober, so I swear I'm not up to anything dubious (well not with this PR anyway!).

Copy link
Contributor

@poornimanayar poornimanayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kjac ,

Looks fine! Merging it in

Poornima

@poornimanayar poornimanayar merged commit 6c5b656 into umbraco:v8/contrib Oct 12, 2020
@poornimanayar
Copy link
Contributor

Thanks once again for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants