Iconpicker: Switch to umb-search-filter #9040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poornimanayar
approved these changes
Oct 12, 2020
|
And merged ⭐ Thanks for your work once again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR changes the search markup to use the
<umb-search-filter>ensuring the markup is aligned throughout the entire backoffice.Edit: Please hold on merging this PR until #9037 has been merged since I decided to refactor a few things in the directive that needs to be in the core before this change is merged. Once the changes to the directive has been merged I need to tweak this PR a little bit as well - Cheers 👍