Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a "System" content type breaks Umbraco #9005

Merged

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Oct 1, 2020

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Creating a content type named "System" has the quite unintended side effect of breaking Umbraco entirely:

image

This was achieved with ModelsBuilder in PureLive (default) mode:

  1. Create the content type "System" - an empty content type is fine.
  2. Reload the backoffice.

This PR adds validation to prevent this specific case of unfortunate content type naming; it looks like this when you attempt to create a "System" content type:

image

There are likely other cases to be found down the road, and once found we can add them to the reservedModelAliases collection in the validator.

Copy link
Contributor

@poornimanayar poornimanayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kjac ,

Many thanks for the PR! It works as advertised. Happy to merge :-)

Poornima

@poornimanayar poornimanayar merged commit e0eadf2 into umbraco:v8/contrib Oct 12, 2020
@poornimanayar
Copy link
Contributor

And merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants