Creating a "System" content type breaks Umbraco #9005
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Creating a content type named "System" has the quite unintended side effect of breaking Umbraco entirely:
This was achieved with ModelsBuilder in
PureLive
(default) mode:This PR adds validation to prevent this specific case of unfortunate content type naming; it looks like this when you attempt to create a "System" content type:
There are likely other cases to be found down the road, and once found we can add them to the
reservedModelAliases
collection in the validator.