Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pass in boolean to umbAutoFocus directive #8799

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Allow to pass in boolean to umbAutoFocus directive #8799

merged 1 commit into from
Sep 30, 2020

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Sep 2, 2020

Prerequisites

  • I have added steps to test this contribution in the description below

Description

This PR allow to pass in truthy values (0/1, 'true'/'false', true/false) to umbAutoFocus similar to preventEnterSubmit and preventDefault directives.

Originally added to this PR #8639 but moved to a separate PR instead.

@bjarnef bjarnef mentioned this pull request Sep 2, 2020
Merged
1 task
@nul800sebastiaan nul800sebastiaan merged commit 5b82264 into umbraco:v8/contrib Sep 30, 2020
@nul800sebastiaan
Copy link
Member

👍 Thanks @bjarnef!

@bjarnef bjarnef deleted the v8/feature/umbautofocus-truthy-values branch September 30, 2020 17:27
@kjac kjac mentioned this pull request Oct 1, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category/api community/pr release/8.10.0 type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjarnef @nul800sebastiaan @umbrabot