Accessibility: Grid config datatype improvements #8712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and focus styles for improving accessibility
1 task
src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/dialogs/layoutconfig.html
Outdated
Show resolved
Hide resolved
|
Good stuff! Thanks again @BatJan! 👍 |
|
@BatJan it seems you missed changing the end tag to a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
During my work on the focus lock for the infinite editor in #8522 I noticed during the testing that the "button" for adding layout or row configurations on the grid content datatype was not tabable since it was wrapped in
<a>without ahrefattribute. But since it's not really a link I've refactored it to be<button>instead and fixed the CSS to add hover and focus styles for the button element.Furthermore I have added some screen reader friendly text labels as well.