Remove usages of angular.forEach in help drawer, content and infinite editors #8544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks the same indeed! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #7718 (in part)
Description
Continuing the effort to minimize the angular dependency, I have rewritten the remaining usages of angular.forEach with the native equivalent in the help drawer, the remaining content editing and infinite editors.
Testing this PR
Basically there should be no noticeable difference when applying this PR; the UI should "just work" as it does now. Validate the following:
Help drawer - tours
Content permission assignments
Section selector
Easiest to test by editing a group.
Group selector
Easiest to test by editing a user.
Content type - property validation
Tree picker - item filtering (simple)
Can be tested with a MNTP configured to allow only certain content types.
Tree picker - item filtering (advanced)
Can be tested setting up member based public access for content.