Remove usages of angular.forEach in property editors #8538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good! 👍 |
|
@kjac in listview search I am seeing a console error when it doesn't return any results.
|
|
@bjarnef good catch, I can reproduce - fix incoming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #7718 (in part)
Description
Continuing the effort to minimize the angular dependency, I have rewritten the remaining usages of angular.forEach with the native equivalent in all property editors.
Testing this PR
Basically there should be no noticeable difference when applying this PR; the property editors should "just work". Validate the following property editors:
Content pickers
For example the Multinode Treepicker
Grid
List view
Best to test this one in the Members section
Nested Content