Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling of confirm actions in tags editor #8528

Merged
merged 8 commits into from
Jul 31, 2020

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Jul 30, 2020

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #8526

Description

This PR fixes some styling issues after merging #5293 and moved trash icon inside umb-confirm-action in #8198

It also fixes issues where no outline was shown on focus.
Since umb-tags-editor is a separate component I have moved the styling to umb-tags-editor.less, so it re-used developers will get the same styling. The property editor still has the umb-tags class which has styling with the limited width.

2020-07-30_20-27-37

Copy link
Member

@nul800sebastiaan nul800sebastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjarnef! This almost fixes the issue with the doctype editor as well, positioning is good, but the icons have somehow disappeared! 🙈

image

Could you have a look at that as well please? 🙏

@bjarnef
Copy link
Contributor Author

bjarnef commented Jul 31, 2020

@nul800sebastiaan sure, will take a look at that as well 👍

@bjarnef
Copy link
Contributor Author

bjarnef commented Jul 31, 2020

@nul800sebastiaan actually the icons are still there, just too much padding.

image

It seemed @kjac changed this in #8504 but it also affect these confirm and cancel buttons. Looking at a fix for this.

@bjarnef
Copy link
Contributor Author

bjarnef commented Jul 31, 2020

@nul800sebastiaan I have reverted the fix from @kjac so it only target <button> element directly below umb-group-builder__property-action (not delete button since this is moved inside umb-confirm-action), but both buttons has the btn-icon class.

So it should be good now 👍

image

image

@nul800sebastiaan nul800sebastiaan merged commit c332298 into umbraco:v8/contrib Jul 31, 2020
@nul800sebastiaan
Copy link
Member

Yep, works great again now! 👍 ⭐

@nul800sebastiaan nul800sebastiaan added community/pr release/8.8.0 release/no-notes This is too small to add to the release notes or fixed after a beta/RC type/bug and removed community/pr release/8.8.0 release/no-notes This is too small to add to the release notes or fixed after a beta/RC type/bug labels Jul 31, 2020
@bjarnef bjarnef deleted the v8/bug/umb-tags-actions branch August 2, 2020 09:45
@nul800sebastiaan nul800sebastiaan added release/8.8.0 release/no-notes This is too small to add to the release notes or fixed after a beta/RC labels Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/no-notes This is too small to add to the release notes or fixed after a beta/RC release/8.8.0 type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New icon directive makes tags look a little weird
3 participants