-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix styling of confirm actions in tags editor #8528
Fix styling of confirm actions in tags editor #8528
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bjarnef! This almost fixes the issue with the doctype editor as well, positioning is good, but the icons have somehow disappeared! 🙈
Could you have a look at that as well please? 🙏
@nul800sebastiaan sure, will take a look at that as well 👍 |
…o v8/bug/umb-tags-actions
@nul800sebastiaan actually the icons are still there, just too much padding. It seemed @kjac changed this in #8504 but it also affect these confirm and cancel buttons. Looking at a fix for this. |
@nul800sebastiaan I have reverted the fix from @kjac so it only target So it should be good now 👍 |
Yep, works great again now! 👍 ⭐ |
Prerequisites
If there's an existing issue for this PR then this fixes #8526
Description
This PR fixes some styling issues after merging #5293 and moved trash icon inside
umb-confirm-action
in #8198It also fixes issues where no outline was shown on focus.
Since
umb-tags-editor
is a separate component I have moved the styling toumb-tags-editor.less
, so it re-used developers will get the same styling. The property editor still has theumb-tags
class which has styling with the limited width.