Don't allow the grid to steal focus on init #8495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one @kjac! Thanks for this! 👍 |
nul800sebastiaan
added
release/8.8.0
release/no-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #8324
Description
See also #8324 for a brilliant issue description
If a Grid configuration has only one layout and one row configuration, the property editor will automatically initialize itself with one layout + row. This makes sense. However, in combination with the excellent accessibility effort in #6804, this causes the grid to steal focus on init - most noticeably when creating new content:
This PR ensures that the auto-focus is not performed on init, but is retained on subsequent row additions to preserve the accessibility: