Some decoupling from underscore => _.each #8475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Looks good, thanks @nathanwoulfe! 👍 |
nul800sebastiaan
changed the title
| @@ -119,7 +113,7 @@ angular.module('umbraco.services') | |||
|
|
|||
| return entityResource.searchAll(args.term, args.canceler).then(function (data) { | |||
|
|
|||
| _.each(data, function (resultByType) { | |||
| data.forEach(resultByType => { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Reproduce by trying to search in the backoffice:
There was a problem hiding this comment.
Hmm. I thought I'd sorted that... I'm guessing data isn't an array, but an object/dictionary. I'll grab the laptop...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes replace
_.eachwith native.forEachin directives (components) and resources - I've sanity checked these locally, all seems to be fine. This is related to #7731 but does not yet complete the _.each removal (figured it's better to have multiple smaller PRs rather than one big one with 50 files modified).Most are like-for-like replacements, with the exception of some like the changes in umbsearch.directive.js where the value is a dictionary not an array, so uses
Object.keys().forEach()because the value is not directly iterable.Made related syntax changes to replace some indexOf calls with includes (easier to read
x.includes(y)compared tox.indexOf(y) !== -1), and converted a few functions to single-line fat-arrows where it made sense to be terser.