Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Divorce: Utilities.equals implementation #7975

Conversation

liamlaverty
Copy link
Contributor

@harry-gordon and I have made some changes for the Angular Divorce issue #7718

Prerequisites

  • ✅ I have added steps to test this contribution in the description below (added unit tests)

Description

Replaced facade with implementation for

  • Utilities.equals

Added the functions to support Utilities.equals

  • Utilities.isDate
  • Utilities.isRegexp
  • Utilities.simpleCompare

Added unit tests for

  • Utilities.equals
  • Utilities.isDate
  • Utilities.isRegExp (although not lots)

@liamlaverty liamlaverty changed the title Angular Divorce Angular Divorce: Utilities.equals implementation Apr 18, 2020
@liamlaverty liamlaverty mentioned this pull request Apr 20, 2020
17 tasks
@nathanwoulfe
Copy link
Contributor

Unit tests! New utilities! You're a legend @liamlavert, great work.

@emmaburstow
Copy link
Contributor

Heyyyy @liamlaverty

Thanks for this work. Wonderful to see this divorce progressing. We'll check it out and let you know if we've any questions.

Emma

@nul800sebastiaan
Copy link
Member

Hey there @liamlaverty and many apologies for the late reply.

First off: there was a PR open for this already: #7860

Second: While we love the idea of decoupling from AngularJS we don't want to then maintain our own custom library that we'd need to maintain and find and fix bugs in etc. So we won't be able to detach this aggressively from AngularJS unfortunately. Therefore we'll close this PR and please note that we won't consider future PRs that introduce large new methods in the Utilities file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants