Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V8: Angular decoupling: isString #7929

Merged
merged 2 commits into from
Apr 10, 2020
Merged

V8: Angular decoupling: isString #7929

merged 2 commits into from
Apr 10, 2020

Conversation

MMasey
Copy link
Contributor

@MMasey MMasey commented Apr 10, 2020

This PR replaces the use of angular.isString in favour of Utilities.isString as part of #7718.

@MMasey MMasey mentioned this pull request Apr 10, 2020
Closed
17 tasks
@emmaburstow
Copy link
Contributor

Hey Mike!

Thanks for the PR! Speak soon 👍

Em

@nul800sebastiaan
Merge branch 'v8/contrib' into pr/7929
c09c448 
# Conflicts:
#	src/Umbraco.Web.UI.Client/src/common/services/umbrequesthelper.service.js
@nul800sebastiaan nul800sebastiaan merged commit 318fcbe into umbraco:v8/contrib Apr 10, 2020
@nul800sebastiaan
Copy link
Member

Thanks very much @MMasey! 🍻

@nathanwoulfe
Copy link
Contributor

@MMasey you're a champion.

@nielslyngsoe
Copy link
Member

@MMasey Great!

@nul800sebastiaan nul800sebastiaan changed the title V8: Angular Divorce: isString V8: Angular decoupling: isString Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category/angularjs-decoupling community/pr release/8.7.0 type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MMasey @emmaburstow @nul800sebastiaan @nathanwoulfe @nielslyngsoe @umbrabot