improvement: update umb-tabs to use better semantic markup #7926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Umbraco.Web.UI/Umbraco/config/lang/en.xml # src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
nul800sebastiaan
requested changes
Apr 10, 2020
There was a problem hiding this comment.
@MMasey Thanks! I have left some comments around buttons, you can accept them if you agree!
| <li ng-click="vm.clickTab($event, tab)" class="umb-tab" role="tab" aria-selected="true" tabindex="0" ng-repeat="tab in vm.tabs | limitTo: vm.maxTabs" data-element="tab-{{tab.alias}}" ng-class="{'umb-tab--active': tab.active, 'umb-tab--error': tabHasError}" val-tab> | ||
| <a>{{ tab.label }}</a> | ||
| <li class="umb-tab" ng-repeat="tab in vm.tabs | limitTo: vm.maxTabs" data-element="tab-{{tab.alias}}" ng-class="{'umb-tab--active': tab.active, 'umb-tab--error': tabHasError}" val-tab> | ||
| <button class="btn-reset umb-tab-button" ng-click="vm.clickTab($event, tab)" role="tab" aria-selected="{tab.active}">{{ tab.label }}</button> |
There was a problem hiding this comment.
Remember any buttons without a type attribute will just submit whatever form it might be in, need to always specify type="button".
Suggested change
| <button class="btn-reset umb-tab-button" ng-click="vm.clickTab($event, tab)" role="tab" aria-selected="{tab.active}">{{ tab.label }}</button> | |
| <button type="button" class="btn-reset umb-tab-button" ng-click="vm.clickTab($event, tab)" role="tab" aria-selected="{tab.active}">{{ tab.label }}</button> |
There was a problem hiding this comment.
Ah yeah good catch, i've updated the PR.
src/Umbraco.Web.UI.Client/src/views/components/tabs/umb-tabs-nav.html
Outdated
Show resolved
Hide resolved
|
I just realised that you had done a change request, not just comments 😂 Either way, it should be sorted now. |
emmaburstow
approved these changes
Apr 10, 2020
|
Sweet, thanks for the update @MMasey no worries about not spotting the changes suggestions! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the markup for the umb-tab used for example in the settings dashboard.
The old version of the code was using anchor tags etc when it should have been using buttons. I've also added some screen reader only text for the more options toggle when on a narrower screen.
The outcome itself visually is minimal, other than only showing the focus state when using the keyboard to navigate via tabbing.