Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Angular Divorce: isFunction #7861

Merged
merged 5 commits into from
Jan 19, 2021
Merged

Conversation

warrenbuckley
Copy link
Contributor

Bye bye angular.isFunction & use Utilities.isFunction

@kjac
Copy link
Contributor

kjac commented Aug 1, 2020

@warrenbuckley good stuff ❤️ I have resolved the merge conflicts.

As it turns out, Utilities isn't loaded on document first load, so it's not applicable for use when detecting if document.angularReady is a function in app.js. However, underscore.js is already loaded at this point, so for now I have replaced Utilities with _ in app.js. See here.

If you're happy with this compromise, I'll merge this PR asap.

@nathanwoulfe
Copy link
Contributor

@kjac how do I magically push to this PR? I have an aliases command for pushing to a pr from a fork, but @warrenbuckley's is a branch, not a fork... There's an additional angular.isFunction I wanted to wipe out before merging...

Copy link
Contributor

@nathanwoulfe nathanwoulfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @warrenbuckley, all good here.
There are still few refs in angular-mocks.js, but I figure those don't really matter - that file is so specific to AngularJs, it will be tossed completely when the UI is rebuilt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants