Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V8: Angular Divorce: isUndefined #7856

Merged
merged 3 commits into from
Dec 10, 2020
Merged

V8: Angular Divorce: isUndefined #7856

merged 3 commits into from
Dec 10, 2020

Conversation

warrenbuckley
Copy link
Contributor

@warrenbuckley warrenbuckley commented Mar 30, 2020 •
edited
Loading

Uses @nathanwoulfe new Utilities global JS to replace angular.isUndefined with Utilities.isUndefinied

  • Also adds the Utilities.js file to the installer LazyLoad (As a replacement was done in installer for DB type)

This is an unscheduled PR done in my own time, so if the lovely PR team can do their normal thing that would be ace @nul800sebastiaan

@warrenbuckley warrenbuckley changed the base branch from v8/contrib to v8/dev March 30, 2020 09:42
@nathanwoulfe nathanwoulfe mentioned this pull request Mar 30, 2020
Closed
17 tasks
@nathanwoulfe nathanwoulfe changed the base branch from v8/dev to v8/contrib December 9, 2020 23:47
@nathanwoulfe
Copy link
Contributor

@warrenbuckley, I updated base to v8/contrib, will review and merge. Will be ace to get these changes all sorted.
🎅

nathanwoulfe
nathanwoulfe approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@nathanwoulfe nathanwoulfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged latest v8/contrib, no issues/conflicts. Changes here all look good, site runs, no errors.

@nathanwoulfe nathanwoulfe merged commit e38e5d6 into v8/contrib Dec 10, 2020
@nathanwoulfe nathanwoulfe deleted the v8/feature/util.isUndefined branch December 10, 2020 00:21
@bjarnef
Copy link
Contributor

bjarnef commented Dec 10, 2020 •
edited
Loading

@warrenbuckley @nathanwoulfe would it make to add a Utilities.isUndefinedOrNull() function as well?
https://stackoverflow.com/questions/17910192/undefined-or-null-for-angularjs

since we are doing this a lot and could simplify it further.

A few examples:

https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/common/resources/auth.resource.js#L240

https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/common/resources/log.resource.js#L89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwoulfe nathanwoulfe nathanwoulfe approved these changes

Assignees
No one assigned
Labels
community/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@warrenbuckley @nathanwoulfe @bjarnef @nul800sebastiaan