Fix #7672 - Image can be added to root of Media when AllowAtRoot is false #7853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjarnef
reviewed
Mar 29, 2020
| localizationService.localize('media_uploadNotAllowed').then(function (message) { notificationsService.warning(message); }); | ||
| } | ||
| else{ | ||
| angular.element(".umb-file-dropzone .file-select").trigger("click"); |
There was a problem hiding this comment.
@olibos you don't need find the element again. It is already available in fileSelect variable.
There was a problem hiding this comment.
My bad! First victim of daylight saving time 😂
Fixed in new version 😉
There was a problem hiding this comment.
@bjarnef have you seen the new commit?
There was a problem hiding this comment.
@olibos yes I did... much better 😁 👍
|
Hey @olibos Thanks for the work here - lovely to see the community collaborating :) We'll take a look and get in touch soon, Emma |
…-of-Media-when-AllowAtRoot-is-false # Conflicts: # src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/mediapicker/mediapicker.controller.js
|
It seems that the latest updated breaks it |
undefined makes JSON.parse crashed!
…-of-Media-when-AllowAtRoot-is-false
# Conflicts: # src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/mediapicker/mediapicker.controller.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7672
With @mmrauta's message suggestion
Description
Set the Image Media Types AllowAtRoot property to false in Setting>Media Types>Image.
Create a Doc Type with a Media Picker property on it and create a node with this Doc Type.
Open the Media Picker.
Click upload while viewing the root of the Media folder. This will not open the file upload window.
Create a new media folder.
Go into the folder.
Click to return to the root.
Click upload while viewing the root. This will no longer open the file upload window.