Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7658 Fix linking account if multiple IDP on common user overlay #7845

Merged
merged 2 commits into from
Apr 9, 2020

Conversation

lillheaton
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

#7658

Description

  1. Setup more than one identity provider
  2. Login and open up the "user overlay"
  3. When clicking either of the connected IDP, it should go to this IDP

@nul800sebastiaan
Copy link
Member

Thanks @lillheaton I've left a request for you, but looks fine otherwise. 👍

FYI: If you add a new commit to this branch and push it, then this PR will update with your updated code.

@nul800sebastiaan nul800sebastiaan merged commit 199d908 into umbraco:v8/contrib Apr 9, 2020
@nul800sebastiaan
Copy link
Member

Thanks for fixing that up @lillheaton!

And congratulations on your first merged PR for Umbraco CMS, great job! 🎉

I've added the a shiny new contributor badge on your profile on Our Umbraco https://our.umbraco.com/members/lillheaton 🏅

Thanks again and I hope to see more contributions from you in the future! 👍

@lars-erik
Copy link
Contributor

Thanks a bunch for this fix! I was about to make a PR myself.
Don't wanna step on any toes or anything, but changing to this.form.submit() would've worked and then ID and name could be removed from the form.
In any case, #H5YR for fixing it.
I'm off to hack older installs and hope I'll remember it when upgrading. 😆

@nul800sebastiaan nul800sebastiaan added release/8.7.0 release/no-notes This is too small to add to the release notes or fixed after a beta/RC labels Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/no-notes This is too small to add to the release notes or fixed after a beta/RC release/8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initiating the wrong provider if multiple identity providers
3 participants