Update CONTRIBUTING.md #7680
Merged
Update CONTRIBUTING.md #7680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syncs header name with summary and fixes link syntax
poornimanayar
suggested changes
Feb 18, 2020
There was a problem hiding this comment.
Hi @PerplexDaniel ,
Thanks for the changes! May I suggest something here. Can we keep the heading as Making changes after the PR is open and change the heading in Table of Contents from 'Making changes after the PR was opened' to 'Making changes after the PR is open'.
Poornima
Changed header back and updated summary instead
|
Hi @poornimanayar, Sure no problem, that's indeed what I put in the description of the PR -- it could be changed the other way around. Just updated the summary and reverted header change. |
poornimanayar
approved these changes
Feb 18, 2020
|
And merged :-) ⭐️ |
poornimanayar
added
release/8.7.0
release/no-notes
nul800sebastiaan
added
community/pr
and removed
release/8.7.0
release/no-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary link and actual header were different, link failed because of that too. Changed header to the summary + link content. Could also be done the other was around if preffered (update summary + link to match header).
Also fixes link syntax (removes space that breaks link functionality)