ContentVariantDisplay: add DisplayName property and use in Umbraco in… #7677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of using AngularJS function
nielslyngsoe
added
the
state/sprint-candidate
|
Still unsure whether we like to have this DisplayName located here. But I think it makes good sense to have it originating from BackEnd. It could be useful for validation messages as well. I will merge it for now, and we will see if we need to change later. |
nielslyngsoe
merged commit 12bb2a4
into
umbraco:v8/feature/AB4550-segments-ui-variant-picker
umbrabot
removed
the
state/sprint-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nielslyngsoe Seperate branch this time, probably easier to check. This is a small change which adds a
DisplayNameproperty to theContentVariantDisplayclass so we can control the variant display name on the server, and in AngularJS do not have to bind to functions which is slower and I know Shannon does not like that either.In addition, developers can now alter the
DisplayNameproperty if desired by using the existing Umbraco eventEditorModelEventManager.SendingContentModelwhich is also useful for the uMarketingSuite.FYI, because this made the
contentvariantutilities.service.jsentirely obsolete (because it was empty) I removed it.This item has been added to our backlog AB#5130