Review Perplex change for Segments #7659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for all cases of culture/segment properties
…riants are saved/published
…//github.com/umbraco/Umbraco-CMS into v8/feature/AB4550-segments-ui-variant-picker
…//github.com/umbraco/Umbraco-CMS into v8/feature/AB4550-segments-ui-variant-picker
…//github.com/umbraco/Umbraco-CMS into v8/feature/AB4550-segments-ui-variant-picker
…o vary by segment
nielslyngsoe
added
the
state/sprint-candidate
|
The code looks good, whether this is the right approach for variants I need someone else to check. But I will merge this into our branch, so you have this available. |
azure-devops-sync
bot
changed the title
|
Yeah actually the whole |
nielslyngsoe
merged commit 1a4e6e5
into
umbraco:v8/feature/AB4550-segments-ui-variant-picker
umbrabot
removed
the
state/sprint-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nielslyngsoe
I ran into an exception when trying to add a new node when it was set to vary by segment only.
This latest commit should fix it. Server-side code would create 0 variants in this case, but it should always create 1 variant (the default / unsegmented variant).
This item has been added to our backlog AB#5083