V8/feature/ab4550 segments ui variant picker #7614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for all cases of culture/segment properties
…riants are saved/published
…//github.com/umbraco/Umbraco-CMS into v8/feature/AB4550-segments-ui-variant-picker
|
@PerplexDaniel Looks good, I'm merging. :-) |
nielslyngsoe
merged commit 124bc27
into
umbraco:v8/feature/AB4550-segments-ui-variant-picker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@nielslyngsoe Amazing work already, looks great! I was checking it for a bit and in the process already made some fixes for stuff I ran into hope that's OK. Sending you these as a PR so you can easily view / test them yourself.
The fixes are mainly for situations where "Vary by culture" is not enabled on property-level or on content-type level. With certain combinations the UI regarding "Inherited by " was not correct and fields were not properly disabled. In addition, in splitview mode where multiple variants are saved/published a variant with culture
nulland some segmentswas not being saved at all.There are probably some more things that need to be refined, for example the
getVariantDisplayNamefunction in Angular might be removed if we introduce aDisplayName(or similar) property on theContentVariantDisplayclass in C# instead. This saves binding to functions in AngularJS which isn't great for performance.