V8: Do not save content when opening the content template #7257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poornimanayar
approved these changes
Dec 27, 2019
There was a problem hiding this comment.
Works well @kjac and this was something that was bugging me, unknown to the fact that something I did actually caused it :(
|
And merged :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
In an effort to make things more accessible, the link that used to open the current content template has been turned into a button (see #7094). As a result, the content editor now saves the current content when you open its template in infinite editing:
If you're editing invariant content you probably won't even notice it being saved. That's not so good.
This issue is much along the lines of #7185, and the fix is the same: Applying an explicit type to the edit button (type="button"), thus explicitly instructing the browser how to interpret it.
Here's the same operation with this PR applied: