Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved the ngdocs for the editor service #7023

Merged
merged 2 commits into from
Dec 19, 2019
Merged

Improved the ngdocs for the editor service #7023

merged 2 commits into from
Dec 19, 2019

Conversation

abjerner
Copy link
Contributor

image

@poornimanayar
Copy link
Contributor

👍 @abjerner

kjac
kjac approved these changes Dec 15, 2019
View reviewed changes
Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🏆 happy to approve.

This is already mentioned in the description, but for good measure... do not merge this until #7022 is merged 😄

@kjac kjac changed the base branch from v8/dev to v8/contrib December 19, 2019 10:32
@kjac kjac merged commit b2195eb into v8/contrib Dec 19, 2019
@kjac
Copy link
Contributor

kjac commented Dec 19, 2019

Merged along with #7022 😄 thanks again, @abjerner

@nul800sebastiaan nul800sebastiaan deleted the v8/fix/editor-service-document-type-editor branch September 14, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjac kjac kjac approved these changes

Assignees
No one assigned
Labels
community/pr hacktoberfest/contrib-2019 release/8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abjerner @poornimanayar @kjac