Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes continually loading banner if there is no current editor state #6987

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Removes continually loading banner if there is no current editor state #6987

merged 1 commit into from
Oct 31, 2019

Conversation

RachBreeze
Copy link
Contributor

The loading banner continues to display when in the following sections:

  • When the creating/editing users
  • When the creating/editing user groups
  • When the creating/editing languages
  • When in the log viewer

The continually loading banner introduced in #6315 and this PR removes it

@RachBreeze
Copy link
Contributor Author

FYI @BatJan has also spotted this issue in the packages section

abjerner
abjerner approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@abjerner abjerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @RachBreeze 👍

I can confirm this fixes the loader issue 😄

@nul800sebastiaan nul800sebastiaan merged commit ce08337 into umbraco:v8/dev Oct 31, 2019
@nul800sebastiaan
Copy link
Member

Whoops! Thanks for fixing it so quickly @RachBreeze ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abjerner abjerner abjerner approved these changes

Assignees
No one assigned
Labels
community/pr hacktoberfest/contrib-2019
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RachBreeze @nul800sebastiaan @abjerner