Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help drawer: Add missing translations #6932

Merged
merged 5 commits into from
Jan 14, 2020
Merged

Help drawer: Add missing translations #6932

merged 5 commits into from
Jan 14, 2020

Conversation

BatJan
Copy link
Contributor

@BatJan BatJan commented Oct 28, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

Description

I noticed some missing translations when having a look in the file so I have added the keys and mapped them in the view.

Copy link
Contributor

@poornimanayar poornimanayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BatJan ,

Works as advertised! Great work as always :-)

Poornima

@poornimanayar
Copy link
Contributor

@BatJan ,

can you fix the merge conflicts against v8/contrib please?

@poornimanayar poornimanayar changed the base branch from v8/dev to v8/contrib December 20, 2019 09:39
Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged from v8/contrib and also added Danish translations while I was at it

@kjac kjac merged commit 0ec3080 into umbraco:v8/contrib Jan 14, 2020
@kjac
Copy link
Contributor

kjac commented Jan 14, 2020

Merged. Thanks again, @BatJan 👏

@kjac kjac added community/pr hacktoberfest/contrib-2019 release/8.6.0 release/no-notes This is too small to add to the release notes or fixed after a beta/RC type/feature labels Jan 14, 2020
@nul800sebastiaan nul800sebastiaan removed the release/no-notes This is too small to add to the release notes or fixed after a beta/RC label Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants