Grid layout config: Replace the old checkbox with the umb-checbox directive #6859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe |
nul800sebastiaan
requested changes
Oct 29, 2019
There was a problem hiding this comment.
I would agree with Bjarne here, this one is better suited to be a toggle. Could you update it to be that please @BatJan?
|
@nul800sebastiaan Done 😉 |
|
Lovely, thanks! 👍 |
emmaburstow
added
community/pr
release/8.3.0
type/feature
and removed
community/pr
release/8.3.0
type/feature
labels
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
I have replaced the old checkbox with the umb-checkbox directive - I have also temporarily added some inline styling to align the checkbox. But that's only until this PR is merged #6858
So before merging this PR please merge the other one and let me update this PR with a proper modifier CSS class 😉
You might also wonder "Why not change the other checkboxes that are revealed when the new one is toggled?" - Well, that requires an extension to the umb-checkbox directive, which I'm having a think about these days to make it as flexible as we need it to be. Stay tuned 👀
Before
After
