Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document type collection: Refactor labels to reference the proper input fields #6838

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Document type collection: Refactor labels to reference the proper input fields #6838

merged 2 commits into from
Oct 25, 2019

Conversation

BatJan
Copy link
Contributor

@BatJan BatJan commented Oct 24, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

Description

This PR is hard to visualize since the label looks the exact same as before. But the difference is that it has a reference to the id of the input field it's attached too, which improves accessibility and makes the input field focused whenever the label is clicked.

Let me know if I need to ellaborate further on this 😃

@elit0451
Copy link
Contributor

Cool change @BatJan 👌
Tested the functionality 🌟 Merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants