Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UmbracoVirtualNodeByUdiRouteHandler #6796

Conversation

Jeavon
Copy link
Contributor

@Jeavon Jeavon commented Oct 21, 2019

This is the same as UmbracoVirtualNodeByIdRouteHandler except it expects a GuidUdi so code can reference the same node across Umbraco Cloud environments etc

Tested with this example:

        var routeGuid = new GuidUdi(Constants.UdiEntityType.Document, new Guid("e8ad9b65-cff6-4952-ac5b-efe56a60db62"));
        RouteTable.Routes.MapUmbracoRoute(
            "Product list by category",
            "category/{customId}",
            new
            {
                controller = "People",
                action = "Index",
                customId = UrlParameter.Optional,
                page = 1
            },
            new UmbracoVirtualNodeByUdiRouteHandler(routeGuid));

@poornimanayar
Copy link
Contributor

Hi @Jeavon ,

Thanks for the work! We will test the PR and get back to you :-)

Poornima

@nul800sebastiaan nul800sebastiaan merged commit 4be1c3b into umbraco:v8/dev Oct 29, 2019
@nul800sebastiaan
Copy link
Member

Lovely @Jeavon, thanks very much! 👍

@nul800sebastiaan
Copy link
Member

Hi there @Jeavon,

First of all: A big #H5YR for contributing to Umbraco during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

We have had another record breaking amount of PR's in both the CMS, Documentation, and other smaller public repositories. You can read all about the numbers in the Umbraco Hacktoberfest round-up blog post.

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

Receive your swag! 👈 Please follow this link to fill out and submit the form, before December 19th 2019.

Following this date we'll be sending out all the swag, which also means that it might not reach your doorstep before February, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The Umbraco PR Team & The Documentation Curators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants