Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Style the umb-overlay header and footer like the rest of the overlays #6727

Merged

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Oct 16, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

Description

The header and footer of the umb-overlay dialog look rather out of place when the dialog is used in "slide-in-from-right" mode; I think they may be leftovers from V7.

Here's a V8 style dialog:

image

...and here are a few select samples of umb-overlay:

image

image

Notice:

  • The height of the header and footer (and how they do not align nicely with the main window header and footer)
  • The font size of the header
  • The border color that separates the dialog content from the header and footer
  • The background color of the footer
  • The lack of padding in the top of the dialog content
  • The white border near the footer when the dialog has a scrollbar

This PR updates the styling of umb-overlay so it looks like a V8 dialog in "slide-in-from-right" mode:

image

image

The styling of umb-overlay when used e.g. for picking items types in Grid or Nested Content remains (largely) unchanged:

image

Testing this PR

Verify that the umb-overlay look and feel is V8-ish 😄

At the time of writing, umb-overlay is used for:

  • Edit dialog when inserting or editing images from RTE
  • User profile dialog when clicking the user avatar in the upper left corner
  • File type picker when uploading new images via the dropzone (provided you have multiple "image" media types)
  • Fields list per search result in the Examine Management dashboard
  • New item type picker in the Grid
  • New item type picker in Nested Content
  • List view YSOD details dialog (I'm not entirely sure how to test this one...)

@emmaburstow
Copy link
Contributor

This is just right. Ok, so we'll check it over and merge if it's all good.

Em

Copy link
Contributor

@poornimanayar poornimanayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kjac ,

Tested and great attempt at bringing consistency!

Poornima

@nul800sebastiaan nul800sebastiaan merged commit c6ab73b into umbraco:v8/dev Oct 24, 2019
@nul800sebastiaan
Copy link
Member

It's looks gr8 to me! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants