V8 - umb-box-header shows values for non-localized and localized title and description

[dawoe]

Prerequisites

• I have added steps to test this contribution in the description below

Description

When using the umb-box-header directive you can set a title attribute and a title-key attribute. When both are filled both values are shown. I would expect the value of the localized title-key to be shown when filled. And the title property only when the title-key is not provided or can not be localized.

Same goes for description and description-key

Steps to reproduce

Copy and paste the following code above the umb-box-content directive in /src/Umbraco.Web.UI.Client/src/views/dashboard/settings/settingsdashboardintro.html file.

<umb-box-header 
	title="Start here" 
	title-key="general_add" 
	description="Non localized description" 
	description-key="general_delete">
</umb-box-header>

Build the front end run your umbraco site. If login and go to the settings section you will see the following in the Welcome dashboard

You can see that both the value from the title and description attribute are shown. But also the translated values for the keys passed in to title-key and description-key

With this PR only the values of the title-key and description-key are shown when the can be localized.

[poornimanayar]

that totally works @dawoe!

[nul800sebastiaan]

Hi there @dawoe,

First of all: A big #H5YR for contributing to Umbraco during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

We have had another record breaking amount of PR's in both the CMS, Documentation, and other smaller public repositories. You can read all about the numbers in the Umbraco Hacktoberfest round-up blog post.

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

Receive your swag! 👈 Please follow this link to fill out and submit the form, before December 19th 2019.

Following this date we'll be sending out all the swag, which also means that it might not reach your doorstep before February, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The Umbraco PR Team & The Documentation Curators