Long running operations causes SQL timeout #6688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the sql provider based on the db type
zpqrtbnk
reviewed
Oct 15, 2019
| foreach (var lockId in lockIds) | ||
| { | ||
| db.Execute(@"SET LOCK_TIMEOUT 1800;"); | ||
| var i = db.Execute(@"UPDATE umbracoLock WITH (REPEATABLEREAD) SET value = value*-1 WHERE id=@id", new { id = lockId }); |
There was a problem hiding this comment.
if by accident the value has been set to zero this does not lock - hence the original CASE
There was a problem hiding this comment.
@zpqrtbnk, is there ways this can happen other than people manipulating the database them self? I wonder why we handle this special case?
There was a problem hiding this comment.
no, it was "assume garbage in" but not critical - you decide
|
Will this help for #6735 as well? |
|
@nul800sebastiaan probably not.. This fixes unintended locking.. Slow queries are still slow. |
…thing invalid directly in the database, and fixed tes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves read/write locking and isolation level to the responsibility of the sql provider based on the db type and changes Sql server to use
ReadCommittedfor normal SQL calls andRepeatableReadfor when working with distributed locks.This is a trimmed down version of this PR #6029
Changes
ReadCommittedand then ensures we only useRepeatableReadwhen creating/reading the distributed locks using the ReadLock/WriteLock methods. This means that long running operations/transactions are not going to block all reads from the database which have resulted in timeout errorsRepeatableReadsince it does not support isolation mode per queryTesting