Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6467 - Removing code references to MacroContainer #6639

Closed

Conversation

Kerl1310
Copy link

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #6467

Description

Removed the code referencing MacroContainer from the project

@nul800sebastiaan
Copy link
Member

Uh oh! I did remove the "up for grabs" from this one, but I guess I forgot to add a link to the existing PR. Maybe you can compare yours with the existing one and see if the existing one is missing anything?

#6518

@nul800sebastiaan
Copy link
Member

You've both changed 32 files, so that's nice and consistent! 😁

@Kerl1310
Copy link
Author

Ah, sorry, didn't notice the removed labels!

@nul800sebastiaan
Copy link
Member

Thanks again @Kerl1310 - I compared the work in the existing PR to this one and you both did the exact same things. Sorry that someone beat you to it! Hope to see more of your work soon though! 👍

@Kerl1310 Kerl1310 deleted the feature/remove-macrocontainer-code branch October 16, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the leftover code from the legacy MacoContainer datatype
2 participants