Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- set the border for the today class on the date picker #6619

Merged
merged 2 commits into from
Oct 16, 2019
Merged

- set the border for the today class on the date picker #6619

merged 2 commits into from
Oct 16, 2019

Conversation

prjseal
Copy link
Contributor

@prjseal prjseal commented Oct 8, 2019

When using the datepicker, today is not highlighted which makes for a poor user experience, as raised in this issue #6618

I was expecting to see today's date highlighted somehow, perhaps like this:

There is a style for the border colour of the element with the today class on it, but there is no border set.

This PR fixes the issue

Before

https://i.imgur.com/Z3AcOiw.jpg

After

https://i.imgur.com/ArWhjYx.jpg

@nul800sebastiaan
Copy link
Member

Thanks Paul, makes sense. We'll have a look soon! 👍

@nul800sebastiaan nul800sebastiaan merged commit 77f2b28 into umbraco:v8/dev Oct 16, 2019
@nul800sebastiaan
Copy link
Member

Nice one @prjseal, works like a charm, cheers! 👍

@nul800sebastiaan
Copy link
Member

Hi there @prjseal,

First of all: A big #H5YR for contributing to Umbraco during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

We have had another record breaking amount of PR's in both the CMS, Documentation, and other smaller public repositories. You can read all about the numbers in the Umbraco Hacktoberfest round-up blog post.

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

Receive your swag! 👈 Please follow this link to fill out and submit the form, before December 19th 2019.

Following this date we'll be sending out all the swag, which also means that it might not reach your doorstep before February, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The Umbraco PR Team & The Documentation Curators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants