V8: Do not warn about unpublishing multiple languages for invariant content #6613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kenn! Thanks for the PR and the stunning-as-usual documentation here. We have loads to look at but as soon as we look at this, we'll let you know. Em |
# Conflicts: # src/Umbraco.Web.UI.Client/src/views/content/delete.html
|
Thank you kindly @kjac! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
If you have multiple languages, the warning in the delete content dialog is the same for variant and invariant content. As the warning mentions unpublishing specific languages, it seems a bit misplaced for culture invariant content:
Also I'm not really a big fan of the wording; "...go and unpublish it instead" comes off a bit rude to me (maybe it's just me?).
With this PR applied, here's how deleting variant content looks (just a change of wording, really):
...and here's now deleting invariant content looks: