Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Enable editing the search results directly from Examine Management #6560

Merged

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Oct 2, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

Description

This PR enables direct access to the search results in Examine Management simply by clicking the result name. It works like this:

examine-search-open-results

With the upcoming ability to search for GUIDs, this might also come in really handy for Cloud support handling.

It only works for well known entities - for now that's content, media and members.

But wait! Isn't this a security concern?

Well.. no. Anyone having access to Examine Management can see the (raw) values of whatever is found when searching, and they can easily construct the URLs for editing the results by means of these values.

Testing this PR

When testing this PR, verify that you can open content, media and member search results by clicking their names.

Also test that you can open search results in a new tab by Ctrl-clicking their names.

Lastly someone should probably test this using a "configured searcher". Apparently there are none of those by default in vLatest and I have no idea how to add them 🤦‍♂

image

@skttl
Copy link
Contributor

skttl commented Oct 2, 2019

What a great addition - but shouldn't it be opening in an infinite editor?

@nul800sebastiaan
Copy link
Member

That's pretty cool, I assume the green link still opens the Examine result?

I don't think it should necessarily open an infinite editor, but that could be the next step.

We'll have a look soon!

@kjac
Copy link
Contributor Author

kjac commented Oct 3, 2019

@skttl I really like the idea of opening in infinite editing (unless you ctrl-click the link). But I don't think it'd work for members, far as I know there's no infinite editing of those?

@skttl
Copy link
Contributor

skttl commented Oct 3, 2019

@kjac #6461 😉😜

@kjac
Copy link
Contributor Author

kjac commented Oct 3, 2019

@skttl would you look at that! I'll dig into it.

@kjac
Copy link
Contributor Author

kjac commented Oct 3, 2019

@skttl totally worth it! Here's how it works now:

examine-management-open-results

@skttl
Copy link
Contributor

skttl commented Oct 3, 2019

So much better ❤

@nul800sebastiaan nul800sebastiaan merged commit dce4f49 into umbraco:v8/dev Oct 14, 2019
@nul800sebastiaan
Copy link
Member

So cool!! 🎉 ⭐️

Great and useful update! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants