Replace checkbox with umb-checkbox in listview publish and unpublish overlay #6544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
I noticed when a document type vary by culture and there is multiple languages configurated, the listview publish and unpublish used traditional checkboxes, while the general unpublish and publish with descendants overlays use
umb-checkbox
component.Furthermore the unpublish button in listview overlay is
warning
style as the general unpublish overlay.I am not sure if it is a bug that it has a condition
ng-if="vm.languages.length > 1"
in "listviewpublish" while it hasng-if="vm.languages.length > 0
in "listviewunpublish"?https://github.com/umbraco/Umbraco-CMS/blob/v8/dev/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/overlays/listviewpublish.html#L7
https://github.com/umbraco/Umbraco-CMS/blob/v8/dev/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/overlays/listviewunpublish.html#L9