V8: Support allowed types for MNTP member picker #6524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 16, 2019 09:39
|
We'll have a look soon, thanks! |
|
Wonderful update @kjac - thanks very much!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
As-is you can pick the allowed types when configuring MNTP as a member picker. However, the picker doesn't respect the allowed types filtering like it does when configured as a content picker. This was uncovered while working on #5983 (see also this comment on the PR fixing #5983)
This PR implements the filtering; when it's applied here's how the MNTP works in member picker mode:
Testing this PR
To test this PR, first create multiple different member types and members of said types.
Configure an MNTP as a member picker which allows only a subset of these types to be picked. Verify that the MNTP only lets you pick these member types, even when searching for members (note: disallowed types are apparently explicitly filtered out when searching - that's not caused by this PR).
Also verify that you can still pick any member type when there is no constraint on allowed member types.