Use aria attributes in dialog markup#6402

Merged

nul800sebastiaan merged 7 commits intoumbraco:v8/devfrom BatJan:feature/accessibility-issue-157

Sep 29, 2019

+23-26

Commits on Sep 22, 2019

Add role, aria-labbelledby, aria-describedby and some id's for the headline and description so things can be paired up nicely.
BatJan
committed
Change the overlay headline from h4 to h1 since when the dialog is open it will lay on top of everything else and by our only context, which is why adding it in a h1 is perfectly fine
BatJan
committed
Adjust line-height since the default for h1 is too much
BatJan
committed
Improve semantics by taking care of the sub headlines being h2 not h5 and hide the icons from screen readers
BatJan
committed
Don't fallback to the content text after all - since it's the same that is visual in the dialog
BatJan
committed
Optimize semantics and style them accordingly
BatJan
committed
Remove stuff that is uneccessary
BatJan
committed