Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leave function for "Save and publish" options popup #6298 #6300

Merged
merged 3 commits into from
Sep 15, 2019
Merged

Add leave function for "Save and publish" options popup #6298 #6300

merged 3 commits into from
Sep 15, 2019

Conversation

BatJan
Copy link
Contributor

@BatJan BatJan commented Sep 7, 2019

Prerequisites

EDIT: I managed to mess up my original PR due to my lousy git skills #6298 - So doing this new one instead 😉

  • I have added steps to test this contribution in the description below

This fixes #6297

Description

The PR for #5884 has just been merged and I realized it did not feature a function for closing the popup when it's being tabbed out of since the deep-blur directive was not introduced until some other PR's I made. So with this PR I have added a "leave" function that will close the popup when it's tabbed out of.

Before*
saveandpublish-popup-before

After
saveandpublish-popup-after

@nul800sebastiaan nul800sebastiaan merged commit dce593d into umbraco:v8/dev Sep 15, 2019
@nul800sebastiaan
Copy link
Member

Super, thanks Jan! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "Save and publish" dropdown disappear when it's being tabbed out of
3 participants