Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Use mculture in content editor for multilingual content #6026

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Jul 30, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #6022

Description

Looks like 88d9e33 introduced a bit of weird behavior for multilingual content; the selected main culture (mculture) is never applied to content when browsing around, thus unless cculture is explicitly specified, content is by default displayed in the default language no matter what is selected as main culture.

Here's a GIF that demonstrates the problem:

mculture-editor-before

This PR fixes it by reverting this change from 88d9e33. When the PR is applied, the content editor once again conforms to the selected main culture:

mculture-editor-after

Stuff to test

  1. Verify that the selected main culture is displayed by default when browsing content - both when using the default and a non-default culture.
  2. Verify that you can override the displayed culture on a per-content basis by selecting another culture in the language dropdown next to the content name.

@bjarnef
Copy link
Contributor

bjarnef commented Jul 31, 2019

There are a few examples of this syntax in the code from this PR #4955 😁

@nul800sebastiaan nul800sebastiaan merged commit 2f84e76 into umbraco:v8/dev Aug 9, 2019
@nul800sebastiaan
Copy link
Member

Nice one! 🎖

@kjac kjac deleted the v8-fix-apply-mculture-in-content-editor branch August 9, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Umbraco v8 - language on content tree and on content window
3 participants