-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility: Create drop down can't be accessed via keyboard #5960
Merged
nul800sebastiaan
merged 13 commits into
umbraco:v8/dev
from
BatJan:feature/a11y-issue-86
Sep 5, 2019
Merged
Accessibility: Create drop down can't be accessed via keyboard #5960
nul800sebastiaan
merged 13 commits into
umbraco:v8/dev
from
BatJan:feature/a11y-issue-86
Sep 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to screen readers
… the logic around creation of a single document type, where it's also possible to create the document type based on a blueprint for the document type
… outside and then remove the dropdown from the view
…dd the createDropdownOpen property to the page object
…own methods in the view
This was referenced Jul 19, 2019
BatJan
changed the title
Accessibility: Issue 86 - Create drop down can't be accessed via keyboard
Accessibility: Create drop down can't be accessed via keyboard
Jul 21, 2019
Thanks for this work Jan. Interesting side-effect you've detailed here. We'll have a good look at this one. Thanks for the detail, as ever. We'll ask if we need to, Em |
# Conflicts: # src/Umbraco.Web.UI.Client/src/common/directives/components/events/events.directive.js # src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/listview.html
Awesome, this is a great bit of work @BatJan - top job! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
This fixes issue 61and 86 from #5277
Description
This affects the "Create" button in "Content" section (When list views are in use) and in the "Media" section. In the "Content" section it can do different things depending on what's been configured as follows
In all of the above scenarios the "Create" button is now possible to tab to. If it's in a state where it has a dropdown it can be opened using the keyboard as well and it's possible to tab through the list of items that appears - The dropdown is closed when it's being tabbed past. In order to achieve this I added a "deep-blur" directive in the events.directive and added a leaveDropdown() method.
The deep-blur directive is a modified version of https://github.com/myplanet/angular-deep-blur/blob/master/angular-deep-blur.js
Apart from fixing the accessibility issues with the listview dropdown feature it appears to have also changed some UX in the scenario where it's possible to insert a single document type or a blueprint for that single document type. Before when you clicked the "Create..." text a new document type would be created immediately and if you clicked the caret you would see a dropdown showing the blueprint, which you could then click in order to create your document type. Since the caret is a
<span>
with it does not have any focus events and is not reachable using the keyboard. I have done 2 before GIF's of this scenario and one after GIF showing my fix for it. In short I've made it act like the scenario where multiple document types are possible to create - See more comments on the GIF's 😃Before a caret would be displayed but when clicking on it a new document type would be created instead of showing the option of creating the document type, or create the document type based on a blueprint. This has now been fixed too. The difference shows in the before/after GIF's below.
Ok, I think it have it all covered now - I hope it's easier to test than it has been for me to describe things properly 😅 Enjoy!
Content Create Single Doctype - Before
Content Create Single Doctype - After
Content Create Single Doctype With Blueprint- Before part 1
This part show how the "Create" button is not possible to tab to using the keyboard.
Content Create Single Doctype With Blueprint- Before part 2
This part shows how the creation of either normal document type or the blueprint of the document type where it's necessary to click the little "Caret" icon to have it appear - In my humble opinion that does not make much sense. Therefore I have changed it in the after GIF to act like it does when it's possible to create multiple document types and blueprints, which also aligns the overall user experience making it easier for the editors to learn and remember.
Content Create Single Doctype With Blueprint - After
Content Create Multiple Doctype With Blueprint - Before
Content Create Multiple Doctype With Blueprint - After
Media Create - Before
Media Create - After