Accessibility: Media uploader widget can't be accessed via keyboard #5944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally as well as non-visually
…rything is nicely centered
BatJan
changed the title
|
Lovely work, Jan. Another win for accessibility. We'll shout if we need you, Em |
|
Thank you @emmaburstow 😃 However I think I ended up changing the added paragraph to say "area" instead of "Canvas" - I'm open for textual suggestions here 😄 |
# Conflicts: # src/Umbraco.Web.UI/Umbraco/config/lang/da.xml # src/Umbraco.Web.UI/Umbraco/config/lang/en.xml # src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
|
Awesome, thanks @BatJan ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
This fixes issue 88 from #5277
Description
In this PR I have changed the
Apart from that I have added a text above the image to provide some more context about what is expected of the user here - I felt that the "- or click here..." was not providing enough context. Especially for editors as well.
However I'm open for suggestions for the text I have added since I'm not sure if my current suggestion is good enough. But I think it's better than having nothing. I'm not sure adding a text like "Drag and drop your files onto the image/dropzone below" is properly accessible - But neither is my current suggestion. But as mentioned, I think it's better than nothing 😃
Below we have the before and after GIF's.
Before
After
