Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Health Check - unable to navigate to additional options via keyboard #5928

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Conversation

BatJan
Copy link
Contributor

@BatJan BatJan commented Jul 17, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

This fixes issue 99 from #5277

Description

I have added a button beneath the container looping over the health checks and moved the click event onto the button in order to make them keyboard accessible - The styling has been adjusted accordingly and everything looks like it's usual self here 😃

But when tabbing there is a difference illustrated in the below GIF's. Before it was not possible to tab to the checks one would be tabbing through the navigation after tabbing past the link "the documentation for more information" - After one will tab straight through the groups 👍 😃

Also I added aria-hidden to the <i> elements since they don't make sense to screen readers - This means that at some point a visually hidden text fallback needs to be added. But I'm going to wait doing that until I know if my proposed extension of the language files in PR #5905 is accepted 😅

Before
health-check-tabbing-before

After
health-check-tabbing-after

@BatJan BatJan changed the title Health Check - unable to navigate to additional options via keyboard (Issue 99 from the accessibility list) Accessibility: Health Check - unable to navigate to additional options via keyboard Jul 21, 2019
@emmaburstow
Copy link
Contributor

Thanks for the work Jan! So nice to see the accessibility of the back office improving one pr at a time :)

We'll shout if we need you

Em

@nul800sebastiaan
Copy link
Member

Thanks @BatJan ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants