Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes race condition in PublishedSnapshotService and more... #5924

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

Shazwazza
Copy link
Contributor

@Shazwazza Shazwazza commented Jul 17, 2019

Fixes #5035

There's an issue in some rare cases where if multiple appdomains startup at once that the nucache files can get locked. This is mostly prevalent on Azure web apps when using the slot swap functionality.

Other things/issues:

  • during slot swap the umbraco url gets corrupted because we blindly just accept the next domain request that comes in is the umbraco url
  • a few TODOs and notes added
  • publicizes the PublishedSnapshotServiceOptions so that devs on startup can choose to not have persisted cache files

@warrenbuckley
Copy link
Contributor

warrenbuckley commented Jul 23, 2019

Code looks fine, just remember we need to come back round to those TODOs @Shazwazza
Reporter/community have confirmed a fix, but I am off to test & sanity check, nothing blows up

@warrenbuckley
Copy link
Contributor

Tested ZIP build and all works fine for me

@warrenbuckley warrenbuckley merged commit bb8356d into v8/8.1 Jul 23, 2019
@warrenbuckley warrenbuckley deleted the v/bugfix/5035-slot-swap2 branch July 23, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants