Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare MB future #5748

Merged
merged 3 commits into from
Jul 2, 2019
Merged

Prepare MB future #5748

merged 3 commits into from
Jul 2, 2019

Conversation

zpqrtbnk
Copy link
Contributor

@zpqrtbnk zpqrtbnk commented Jul 1, 2019

Prepare for MB future by making it possible to unplug Umbraco.ModelsBuilder in a nice way and replace it.

Prepare MB future
44e567a 
- implement manifest filters to tweak manifests after they have been parsed
- make IEditorValidator public
- stop relying on InternalsVisibleTo Umbraco.ModelsBuilder
@zpqrtbnk zpqrtbnk mentioned this pull request Jul 1, 2019
Closed
@azure-devops-sync
Copy link

azure-devops-sync bot commented Jul 1, 2019 •
edited by Shazwazza
Loading

This item has been added to our backlog AB#1560

Shazwazza
Shazwazza suggested changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@Shazwazza Shazwazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zpqrtbnk One question about the usage of List<> but also just need to understand what these changes are doing. Publicizing some stuff makes sense but I don't really know what the rest is doing?

src/Umbraco.Core/Manifest/IManifestFilter.cs Show resolved Hide resolved
@zpqrtbnk
Copy link
Contributor Author

zpqrtbnk commented Jul 2, 2019

Description of changes:

Introduce a IManifestFilter - after manifests are read from the file system, but before they are merged into "the manifest", filters can tweak the list of manifests that have been read - thus allowing to programatically remove manifests, alter manifests, or inject virtual manifests.

Why? Because in some cases we may want to entirely disable some stuff that are introduced by a package manifest, and the APIs don't fully allow us to do so.

Make IEditorValidator public - and all related stuff.

Why? Because otherwise it is impossible to implement another models builder that can validate property aliases.

Cleanup GridEditorConfig - use the injected manifest parser.

Why? Because that was a TODO.

@Shazwazza Shazwazza merged commit c03cd81 into v8/dev Jul 2, 2019
@Shazwazza Shazwazza deleted the v8/feature/mb-embed-prepare branch July 2, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shazwazza Shazwazza Shazwazza requested changes

Assignees
No one assigned
Labels
release/8.1.0 type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zpqrtbnk @Shazwazza @nul800sebastiaan @clausjensen @umbrabot